Summary: | REGRESSION (Safari 15.4): Focused element doesn't render outline when it has an underline | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matt <matted47> | ||||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | Safari 14 | ||||||||||
Hardware: | Mac (Apple Silicon) | ||||||||||
OS: | macOS 11 | ||||||||||
Attachments: |
|
Description
Matt
2022-04-08 05:25:04 PDT
> Tabbing back & forth does sometimes show the outline, which is also sometimes partially left there once focus is moved on.
This makes me thinks its a repaint under-invalidation bug?
Created attachment 457078 [details]
Test reduction
It looks like ink overflow issue (that we fail to compute the proper ink overflow for outline). Interestingly outline does not show up as ink overflow (as opposed to like text-shadow). Instead it needs some special handling (expanding repaint top/bottom etc) which has not been adopted in the modern line layout integration layer. The double outline is visible when using Safari 15.3 on macOS 12.2.1, so this looks like a regression. I can reproduce with Safari 15.4. (In reply to Alexey Proskuryakov from comment #7) > The double outline is visible when using Safari 15.3 on macOS 12.2.1, so > this looks like a regression. I can reproduce with Safari 15.4. Sure it is. -> "which has not been adopted in the modern line layout integration layer." (In reply to zalan from comment #8) > (In reply to Alexey Proskuryakov from comment #7) > > The double outline is visible when using Safari 15.3 on macOS 12.2.1, so > > this looks like a regression. I can reproduce with Safari 15.4. > Sure it is. -> "which has not been adopted in the modern line layout > integration layer." I should have been more explicit about it by adding the regression prefix. Created attachment 457126 [details]
Patch
Created attachment 457160 [details]
Patch
Committed r292679 (249471@main): <https://commits.webkit.org/249471@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457160 [details]. |