Bug 238948

Summary: [MSE] Improve SourceBuffer memory cost reporting
Product: WebKit Reporter: Enrique Ocaña <eocanha>
Component: MediaAssignee: Enrique Ocaña <eocanha>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, jer.noble, kondapallykalyan, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Enrique Ocaña
Reported 2022-04-07 11:12:23 PDT
Properly implementing the memoryCost() API in SourceBuffer would improve memory awareness when garbage collecting.
Attachments
Patch (4.82 KB, patch)
2022-04-07 11:25 PDT, Enrique Ocaña 		no flags
DetailsFormatted DiffDiff
Patch (4.81 KB, patch)
2022-04-19 06:41 PDT, Enrique Ocaña 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Enrique Ocaña
Comment 1 2022-04-07 11:25:41 PDT
Created attachment 456950 [details] Patch
Radar WebKit Bug Importer
Comment 2 2022-04-14 11:13:12 PDT
<rdar://problem/91765758>
Enrique Ocaña
Comment 3 2022-04-19 06:41:28 PDT
Created attachment 457884 [details] Patch
Enrique Ocaña
Comment 4 2022-04-19 06:44:50 PDT
This latest patch returns m_extraMemoryCost instead of m_reportedExtraMemoryCost (which was a mistake) in SourceBuffer::memoryCost().
EWS
Comment 5 2022-04-22 04:42:08 PDT
Committed r293216 (249885@main): <https://commits.webkit.org/249885@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457884 [details].
Note You need to log in before you can comment on or make changes to this bug.