Bug 238938

Summary: Remove unneeded CoreIPC messages + handlers related to StorageManagerSet.
Product: WebKit Reporter: Gavin <gavin.p>
Component: WebKit Process ModelAssignee: Gavin <gavin.p>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, cdumez, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch none

Gavin
Reported 2022-04-07 08:18:01 PDT
Remove unneeded CoreIPC messages + handlers related to StorageManagerSet.
Attachments
Patch (9.01 KB, patch)
2022-04-07 08:21 PDT, Gavin 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (9.33 KB, patch)
2022-04-07 09:07 PDT, Gavin 		no flags
DetailsFormatted DiffDiff
Patch (39.16 KB, patch)
2022-04-07 11:50 PDT, Gavin 		no flags
DetailsFormatted DiffDiff
Patch (39.19 KB, patch)
2022-04-08 07:56 PDT, Gavin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Gavin
Comment 1 2022-04-07 08:21:26 PDT
Created attachment 456928 [details] Patch
Gavin
Comment 2 2022-04-07 08:22:24 PDT
I think we can probably remove some of the implementation too. But wanted to do an initial EWS pass to confirm these aren't needed.
Gavin
Comment 3 2022-04-07 09:07:57 PDT
Created attachment 456933 [details] Patch
Gavin
Comment 4 2022-04-07 11:50:33 PDT
Created attachment 456952 [details] Patch
Chris Dumez
Comment 5 2022-04-08 07:25:03 PDT
Comment on attachment 456952 [details] Patch r=me
EWS
Comment 6 2022-04-08 07:34:30 PDT
/Volumes/Data/worker/Commit-Queue/build/Source/WebKit/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Gavin
Comment 7 2022-04-08 07:56:42 PDT
Created attachment 457069 [details] Patch
Gavin
Comment 8 2022-04-08 07:58:03 PDT
@Chris - please can I get another r?. I've not changed the code, I've just updated the change log as I previously deleted the "Reviewed by NOBODY (OOPS!)." and commit-queue got upset.
Chris Dumez
Comment 9 2022-04-08 08:01:15 PDT
(In reply to Gavin from comment #8) > @Chris - please can I get another r?. I've not changed the code, I've just > updated the change log as I previously deleted the "Reviewed by NOBODY > (OOPS!)." and commit-queue got upset. Sure, but in the future, you can just put my name as the reviewer in the ChangeLog to avoid that.
EWS
Comment 10 2022-04-08 13:28:14 PDT
Committed r292631 (249451@main): <https://commits.webkit.org/249451@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457069 [details].
Radar WebKit Bug Importer
Comment 11 2022-04-08 13:29:16 PDT
<rdar://problem/91499896>
Alex Christensen
Comment 12 2022-07-01 11:57:10 PDT
*** Bug 211157 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.