Summary: | Remove unneeded CoreIPC messages + handlers related to StorageManagerSet. | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gavin <gavin.p> | ||||||||||
Component: | WebKit Process Model | Assignee: | Gavin <gavin.p> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | achristensen, annulen, cdumez, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | Other | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Gavin
2022-04-07 08:18:01 PDT
Created attachment 456928 [details]
Patch
I think we can probably remove some of the implementation too. But wanted to do an initial EWS pass to confirm these aren't needed. Created attachment 456933 [details]
Patch
Created attachment 456952 [details]
Patch
Comment on attachment 456952 [details]
Patch
r=me
/Volumes/Data/worker/Commit-Queue/build/Source/WebKit/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Created attachment 457069 [details]
Patch
@Chris - please can I get another r?. I've not changed the code, I've just updated the change log as I previously deleted the "Reviewed by NOBODY (OOPS!)." and commit-queue got upset. (In reply to Gavin from comment #8) > @Chris - please can I get another r?. I've not changed the code, I've just > updated the change log as I previously deleted the "Reviewed by NOBODY > (OOPS!)." and commit-queue got upset. Sure, but in the future, you can just put my name as the reviewer in the ChangeLog to avoid that. Committed r292631 (249451@main): <https://commits.webkit.org/249451@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457069 [details]. *** Bug 211157 has been marked as a duplicate of this bug. *** |