Bug 238929

Summary: Move long-enabled preferences away from experimental
Product: WebKit Reporter: Sam Sneddon [:gsnedders] <gsnedders>
Component: New BugsAssignee: Sam Sneddon [:gsnedders] <gsnedders>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: bdakin, beidson, bfulgham, thorton, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch none

Sam Sneddon [:gsnedders]
Reported 2022-04-07 06:24:47 PDT
Move long-enabled preferences away from experimental
Attachments
Patch (31.44 KB, patch)
2022-04-07 06:25 PDT, Sam Sneddon [:gsnedders]
ews-feeder: commit-queue-
Patch (31.46 KB, patch)
2022-04-07 08:37 PDT, Sam Sneddon [:gsnedders]
no flags
Sam Sneddon [:gsnedders]
Comment 1 2022-04-07 06:25:53 PDT
Sam Sneddon [:gsnedders]
Comment 2 2022-04-07 08:37:32 PDT
Tim Horton
Comment 3 2022-04-07 10:14:28 PDT
Comment on attachment 456930 [details] Patch Very nice!
Brent Fulgham
Comment 4 2022-04-07 10:19:36 PDT
Comment on attachment 456930 [details] Patch Nice!
EWS
Comment 5 2022-04-07 18:36:15 PDT
Committed r292586 (249419@main): <https://commits.webkit.org/249419@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456930 [details].
Radar WebKit Bug Importer
Comment 6 2022-04-07 18:37:16 PDT
Truitt Savell
Comment 7 2022-04-08 16:41:36 PDT
Reverted r292586 for reason: Caused 50+ test failures on Mac wk1 Committed r292642 (249462@trunk): <https://commits.webkit.org/249462@trunk>
Tim Horton
Comment 9 2022-04-15 23:59:10 PDT
The trick here, I think, is that moving them from Experimental to normal means they no longer get implicitly enabled by DRT. Previously, ReferrerPolicyAttributeEnabled was disabled by default in WebKit1, but enabled in DRT (along with all other experimental features). Now it's disabled by default in WebKit1, period, and the tests fail.
Sam Sneddon [:gsnedders]
Comment 10 2023-05-31 13:28:04 PDT
We've done a lot of work on tidying up preferences over the past year, so it seems like this can probably be safely closed?
Brent Fulgham
Comment 11 2023-05-31 14:21:55 PDT
Oh yes! Thank you.
Note You need to log in before you can comment on or make changes to this bug.