| Summary: | Split TestWebKitAPI.GPUProcess.ExitsUnderMemoryPressureWebRTCCase in more tests | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cdumez, eric.carlson, webkit-bug-importer, youennf | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
youenn fablet
2022-04-07 05:36:47 PDT
Created attachment 456915 [details]
Patch
Created attachment 456929 [details]
Patch
Comment on attachment 456929 [details]
Patch
r=me once the bots are happy
Created attachment 457042 [details]
Patch for landing
Committed r292705 (249497@main): <https://commits.webkit.org/249497@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457042 [details]. The issue seems related with audio capture. I'll update the tests to prevent flakiness on bots. (In reply to youenn fablet from comment #7) > The issue seems related with audio capture. > I'll update the tests to prevent flakiness on bots. Why is updating the test the right thing to do? Isn't it indicative of a bug where the GPUProcess gets relaunched unnecessarily after a crash? That's the whole point of this test. (In reply to Chris Dumez from comment #8) > (In reply to youenn fablet from comment #7) > > The issue seems related with audio capture. > > I'll update the tests to prevent flakiness on bots. > > Why is updating the test the right thing to do? Isn't it indicative of a bug > where the GPUProcess gets relaunched unnecessarily after a crash? > > That's the whole point of this test. The test was initially disabled to reduce EWS load. I split it to investigate. I am now disabling the sub test to reduce EWS load again. I still plan to investigate the underlying issue so that we can reenable the test in bots. (In reply to youenn fablet from comment #9) > (In reply to Chris Dumez from comment #8) > > (In reply to youenn fablet from comment #7) > > > The issue seems related with audio capture. > > > I'll update the tests to prevent flakiness on bots. > > > > Why is updating the test the right thing to do? Isn't it indicative of a bug > > where the GPUProcess gets relaunched unnecessarily after a crash? > > > > That's the whole point of this test. > > The test was initially disabled to reduce EWS load. I split it to > investigate. > I am now disabling the sub test to reduce EWS load again. > I still plan to investigate the underlying issue so that we can reenable the > test in bots. Oh, I misunderstood. Ok. |