Bug 238927

Summary:

Split TestWebKitAPI.GPUProcess.ExitsUnderMemoryPressureWebRTCCase in more tests

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebRTC

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, eric.carlson, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch for landing	none

youenn fablet

Reported 2022-04-07 05:36:47 PDT

Split TestWebKitAPI.GPUProcess.ExitsUnderMemoryPressureWebRTCCase in more tests

Attachments
Patch (4.85 KB, patch) 2022-04-07 05:38 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (5.48 KB, patch) 2022-04-07 08:27 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch for landing (5.47 KB, patch) 2022-04-08 04:14 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2022-04-07 05:38:29 PDT

Created attachment 456915 [details] Patch

youenn fablet

Comment 2 2022-04-07 08:27:42 PDT

Created attachment 456929 [details] Patch

Eric Carlson

Comment 3 2022-04-07 09:08:42 PDT

Comment on attachment 456929 [details] Patch r=me once the bots are happy

youenn fablet

Comment 4 2022-04-08 04:14:10 PDT

Created attachment 457042 [details] Patch for landing

EWS

Comment 5 2022-04-11 01:31:00 PDT

Committed r292705 (249497@main): <https://commits.webkit.org/249497@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457042 [details].

Radar WebKit Bug Importer

Comment 6 2022-04-11 01:32:15 PDT

<rdar://problem/91553348>

youenn fablet

Comment 7 2022-04-12 00:44:55 PDT

The issue seems related with audio capture. I'll update the tests to prevent flakiness on bots.

Chris Dumez

Comment 8 2022-04-12 07:14:04 PDT

(In reply to youenn fablet from comment #7) > The issue seems related with audio capture. > I'll update the tests to prevent flakiness on bots. Why is updating the test the right thing to do? Isn't it indicative of a bug where the GPUProcess gets relaunched unnecessarily after a crash? That's the whole point of this test.

youenn fablet

Comment 9 2022-04-12 07:19:25 PDT

(In reply to Chris Dumez from comment #8) > (In reply to youenn fablet from comment #7) > > The issue seems related with audio capture. > > I'll update the tests to prevent flakiness on bots. > > Why is updating the test the right thing to do? Isn't it indicative of a bug > where the GPUProcess gets relaunched unnecessarily after a crash? > > That's the whole point of this test. The test was initially disabled to reduce EWS load. I split it to investigate. I am now disabling the sub test to reduce EWS load again. I still plan to investigate the underlying issue so that we can reenable the test in bots.

Chris Dumez

Comment 10 2022-04-12 07:20:57 PDT

(In reply to youenn fablet from comment #9) > (In reply to Chris Dumez from comment #8) > > (In reply to youenn fablet from comment #7) > > > The issue seems related with audio capture. > > > I'll update the tests to prevent flakiness on bots. > > > > Why is updating the test the right thing to do? Isn't it indicative of a bug > > where the GPUProcess gets relaunched unnecessarily after a crash? > > > > That's the whole point of this test. > > The test was initially disabled to reduce EWS load. I split it to > investigate. > I am now disabling the sub test to reduce EWS load again. > I still plan to investigate the underlying issue so that we can reenable the > test in bots. Oh, I misunderstood. Ok.

Note You need to log in before you can comment on or make changes to this bug.