Bug 238899

Summary: [:has() pseudo-class] Support invalidation for autofill pseudo classes
Product: WebKit Reporter: Tim Nguyen (:ntim) <ntim>
Component: CSSAssignee: Tim Nguyen (:ntim) <ntim>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, esprehn+autocc, ews-watchlist, gyuyoung.kim, koivisto, mifenton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 234556    
Attachments:
Description Flags
[fast-cq] Patch none

Description Tim Nguyen (:ntim) 2022-04-06 15:26:16 PDT
There are multiple autofill pseudo classes, it should be a matter of using PseudoClassChangeInvalidation instead of invalidateStyleForSubtree().
Comment 1 Tim Nguyen (:ntim) 2022-04-06 23:45:19 PDT
Created attachment 456895 [details]
[fast-cq] Patch
Comment 2 Antti Koivisto 2022-04-07 05:45:41 PDT
Comment on attachment 456895 [details]
[fast-cq] Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456895&action=review

> LayoutTests/ChangeLog:9
> +        * fast/forms/input-autofilled-expected.txt:
> +        * fast/forms/input-autofilled.html:

Please add (or expand) a WPT.
Comment 3 Tim Nguyen (:ntim) 2022-04-07 05:55:50 PDT
Comment on attachment 456895 [details]
[fast-cq] Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456895&action=review

>> LayoutTests/ChangeLog:9
>> +        * fast/forms/input-autofilled.html:
> 
> Please add (or expand) a WPT.

You can't use `window.internals.setAutofilled(input, true);` in WPT unfortunately.
Comment 4 EWS 2022-04-07 05:59:10 PDT
Committed r292531 (249369@main): <https://commits.webkit.org/249369@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456895 [details].
Comment 5 Radar WebKit Bug Importer 2022-04-07 06:00:16 PDT
<rdar://problem/91410097>