Bug 238869

Summary: Fix the address sanitizer build when building with gcc
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: Tools / TestsAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, pnormand, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch none

Description Martin Robinson 2022-04-06 08:49:14 PDT 
The build currently fails when trying to turn on the address sanitizer using the gcc compiler.
Comment 1 Martin Robinson 2022-04-06 08:52:03 PDT 
Created attachment 456823 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2022-04-13 08:50:15 PDT 
<rdar://problem/91692190>
Comment 3 Philippe Normand 2022-04-18 02:58:43 PDT 
Comment on attachment 456823 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456823&action=review

> Source/JavaScriptCore/runtime/ConfigFile.cpp:248
>          m_filename[s_maxPathLength] = '\0';

Missing _END before leaving scope?
Comment 4 Martin Robinson 2022-04-18 03:03:46 PDT 
Created attachment 457803 [details]
Patch
Comment 5 Martin Robinson 2022-04-18 03:04:22 PDT 
(In reply to Philippe Normand from comment #3)
> Comment on attachment 456823 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=456823&action=review
> 
> > Source/JavaScriptCore/runtime/ConfigFile.cpp:248
> >          m_filename[s_maxPathLength] = '\0';
> 
> Missing _END before leaving scope?

Oof. Yes. Thanks for spotting that. I've uploaded a new version of the change.
Comment 6 EWS 2022-04-18 05:44:37 PDT 
Found 1 new test failure: http/tests/privateClickMeasurement/store-private-click-measurement-with-source-nonce.html
Comment 7 EWS 2022-04-19 01:49:25 PDT 
Committed r293010 (249749@main): <https://commits.webkit.org/249749@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457803 [details].