Bug 238857

Summary: Remove some @apply leftover code
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, ntim, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Antti Koivisto
Reported 2022-04-06 01:15:37 PDT
@apply is not a thing.
Attachments
Patch (10.05 KB, patch)
2022-04-06 01:18 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2022-04-06 01:18:21 PDT
Created attachment 456789 [details] Patch
Tim Nguyen (:ntim)
Comment 2 2022-04-06 01:37:42 PDT
Comment on attachment 456789 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456789&action=review > Source/WebCore/css/parser/CSSVariableParser.cpp:91 > + case AtKeywordToken: > break; Is it possible to delete this? `default:` bellow seems to handle it.
Antti Koivisto
Comment 3 2022-04-06 01:56:42 PDT
> Is it possible to delete this? `default:` bellow seems to handle it. A better direction might be to eliminate the default branch. Then everyone who adds a new token type needs to consider this code too.
EWS
Comment 4 2022-04-06 02:17:51 PDT
Committed r292455 (249306@main): <https://commits.webkit.org/249306@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456789 [details].
Radar WebKit Bug Importer
Comment 5 2022-04-06 02:18:18 PDT
<rdar://problem/91342745>
Note You need to log in before you can comment on or make changes to this bug.