Bug 238848

Summary: FilterImage::imageBufferFromPixelBuffer() can trigger accelerated buffers in the web process
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, sabouhallawa, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Simon Fraser (smfr)
Reported 2022-04-05 16:12:35 PDT
FilterImage::imageBufferFromPixelBuffer() makes an accelerated buffer, but doesn't use a RenderingPurpose option, so can trigger accelerated rendering in the web process. This will break when IOKit blocking is enabled.
Attachments
Patch (1.70 KB, patch)
2022-04-06 14:00 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-04-05 16:12:51 PDT
<rdar://problem/91322362>
Simon Fraser (smfr)
Comment 2 2022-04-05 16:21:02 PDT
Said says this code only runs in the GPUP.
Simon Fraser (smfr)
Comment 3 2022-04-06 13:56:12 PDT
I verified that this is only called in the GPU process.
Simon Fraser (smfr)
Comment 4 2022-04-06 13:57:46 PDT
I'll use this to remove the comment.
Simon Fraser (smfr)
Comment 5 2022-04-06 13:59:09 PDT
*** Bug 238889 has been marked as a duplicate of this bug. ***
Simon Fraser (smfr)
Comment 6 2022-04-06 14:00:19 PDT
Created attachment 456858 [details] Patch
EWS
Comment 7 2022-04-06 15:22:52 PDT
Committed r292511 (249353@main): <https://commits.webkit.org/249353@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456858 [details].
Note You need to log in before you can comment on or make changes to this bug.