Bug 238848

Summary:

FilterImage::imageBufferFromPixelBuffer() can trigger accelerated buffers in the web process

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

Layout and Rendering

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, sabouhallawa, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

Safari Technology Preview

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Simon Fraser (smfr) 2022-04-05 16:12:35 PDT

FilterImage::imageBufferFromPixelBuffer() makes an accelerated buffer, but doesn't use a RenderingPurpose option, so can trigger accelerated rendering in the web process. This will break when IOKit blocking is enabled.

Comment 1 Radar WebKit Bug Importer 2022-04-05 16:12:51 PDT

<rdar://problem/91322362>

Comment 2 Simon Fraser (smfr) 2022-04-05 16:21:02 PDT

Said says this code only runs in the GPUP.

Comment 3 Simon Fraser (smfr) 2022-04-06 13:56:12 PDT

I verified that this is only called in the GPU process.

Comment 4 Simon Fraser (smfr) 2022-04-06 13:57:46 PDT

I'll use this to remove the comment.

Comment 5 Simon Fraser (smfr) 2022-04-06 13:59:09 PDT

*** Bug 238889 has been marked as a duplicate of this bug. ***

Comment 6 Simon Fraser (smfr) 2022-04-06 14:00:19 PDT

Created attachment 456858 [details]
Patch

Comment 7 EWS 2022-04-06 15:22:52 PDT

Committed r292511 (249353@main): <https://commits.webkit.org/249353@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456858 [details].