Bug 238843

Summary:

Web Inspector: Regression(r291729) The result of logging $0 to the console shows overlapping `$0` and `$[n]` after the node

Product:

WebKit

Reporter:

Patrick Angle <pangle>

Component:

Web Inspector

Assignee:

Patrick Angle <pangle>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, hi, inspector-bugzilla-changes, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

238226

Bug Blocks:

Attachments:

Description	Flags
Screenshot of Issue	none
Patch v1.0	none

Description Patrick Angle 2022-04-05 15:34:17 PDT

Created attachment 456760 [details]
Screenshot of Issue

r291729 is missing a check that the `DOMTreeOutline` is actually supposed to show an indicator for the inspected node, which means other usage of `DOMTreeOutline` (the console, the sources tab, etc.) are showing the $0 indicator as well now.

Comment 1 Radar WebKit Bug Importer 2022-04-05 15:34:28 PDT

<rdar://problem/91319491>

Comment 2 Patrick Angle 2022-04-05 15:37:17 PDT

Created attachment 456761 [details]
Patch v1.0

Comment 3 Devin Rousso 2022-04-05 15:39:29 PDT

Comment on attachment 456761 [details]
Patch v1.0

rs=me

Comment 4 EWS 2022-04-05 16:54:03 PDT

Committed r292441 (249294@main): <https://commits.webkit.org/249294@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456761 [details].