Bug 238814

Summary: [WebAuthn] Support all CTAP transports and remove gesture requirement for virtual authenticators
Product: WebKit Reporter: pascoe <pascoe>
Component: WebKit Misc.Assignee: pascoe <pascoe>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description pascoe@apple.com 2022-04-05 10:03:57 PDT 
The user gesture prompt causes wpt tests to hang. We already support CTAP virtual authenticators with transport=usb, this bug should add support for the nfc and ble transports.
Comment 1 Radar WebKit Bug Importer 2022-04-05 10:04:07 PDT 
<rdar://problem/91300515>
Comment 2 pascoe@apple.com 2022-04-05 10:57:49 PDT 
Created attachment 456724 [details]
Patch
Comment 3 Brent Fulgham 2022-04-05 11:06:29 PDT 
Comment on attachment 456724 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456724&action=review

This seems fine as long as we don't mis-advertise support to relying parties. Can you confirm before landing, please?

> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:67
> +        ASSERT_UNUSED(addResult, addResult.isNewEntry);

We do not support Ble devices at present -- does allowing this here cause us to mis-state our hardware feature support to actually relying parties (as opposed to the test infrastructure?)
Comment 4 pascoe@apple.com 2022-04-06 14:29:40 PDT 
Created attachment 456859 [details]
Patch for landing
Comment 5 EWS 2022-04-07 22:41:21 PDT 
Committed r292593 (249426@main): <https://commits.webkit.org/249426@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456859 [details].