Bug 238787

Summary: [CSS-Contain] Add support for contain: inline-size
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, koivisto, kondapallykalyan, macpherson, menard, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

zalan
Reported 2022-04-04 20:37:19 PDT
ssia
Attachments
Patch (12.48 KB, patch)
2022-04-04 21:23 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (12.68 KB, patch)
2022-04-05 07:51 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2022-04-04 21:23:32 PDT
Created attachment 456666 [details] Patch
Antti Koivisto
Comment 2 2022-04-05 06:34:29 PDT
Comment on attachment 456666 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456666&action=review > Source/WebCore/rendering/RenderBlockFlow.cpp:348 > + if (!(shouldApplySizeContainment(*this) || shouldApplyInlineSizeContainment(*this))) { bool shouldApplyContainment = might make this more readable.
Antti Koivisto
Comment 3 2022-04-05 07:04:11 PDT
Comment on attachment 456666 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456666&action=review > LayoutTests/imported/w3c/web-platform-tests/css/css-contain/parsing/contain-computed-expected.txt:16 > +FAIL Property contain value 'inline-size layout style paint' assert_equals: expected "inline-size layout style paint" but got "layout style paint inline-size" Maybe these could be arranged to canonical order trivially?
zalan
Comment 4 2022-04-05 07:51:00 PDT
Created attachment 456698 [details] Patch
EWS
Comment 5 2022-04-05 08:45:53 PDT
Committed r292394 (249259@main): <https://commits.webkit.org/249259@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456698 [details].
Radar WebKit Bug Importer
Comment 6 2022-04-05 08:46:17 PDT
<rdar://problem/91295975>
Note You need to log in before you can comment on or make changes to this bug.