Bug 238787 - [CSS-Contain] Add support for contain: inline-size
Summary: [CSS-Contain] Add support for contain: inline-size
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-04 20:37 PDT by zalan
Modified: 2022-04-05 08:46 PDT (History)
14 users (show)

See Also:

Attachments
Patch (12.48 KB, patch)
2022-04-04 21:23 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (12.68 KB, patch)
2022-04-05 07:51 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-04-04 20:37:19 PDT 
ssia
Comment 1 zalan 2022-04-04 21:23:32 PDT 
Created attachment 456666 [details]
Patch
Comment 2 Antti Koivisto 2022-04-05 06:34:29 PDT 
Comment on attachment 456666 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456666&action=review

> Source/WebCore/rendering/RenderBlockFlow.cpp:348
> +    if (!(shouldApplySizeContainment(*this) || shouldApplyInlineSizeContainment(*this))) {

bool shouldApplyContainment = 

might make this more readable.
Comment 3 Antti Koivisto 2022-04-05 07:04:11 PDT 
Comment on attachment 456666 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456666&action=review

> LayoutTests/imported/w3c/web-platform-tests/css/css-contain/parsing/contain-computed-expected.txt:16
> +FAIL Property contain value 'inline-size layout style paint' assert_equals: expected "inline-size layout style paint" but got "layout style paint inline-size"

Maybe these could be arranged to canonical order trivially?
Comment 4 zalan 2022-04-05 07:51:00 PDT 
Created attachment 456698 [details]
Patch
Comment 5 EWS 2022-04-05 08:45:53 PDT 
Committed r292394 (249259@main): <https://commits.webkit.org/249259@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456698 [details].
Comment 6 Radar WebKit Bug Importer 2022-04-05 08:46:17 PDT 
<rdar://problem/91295975>