Bug 238739

Summary:

<attachment> styles get injected regardless of AttachmentElementEnabled runtime setting

Product:

WebKit

Reporter:

Tim Nguyen (:ntim) <ntim>

Component:

CSS

Assignee:

Tim Nguyen (:ntim) <ntim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

changseok, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kondapallykalyan, macpherson, menard, pdr, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=238960

Bug Depends on:

Bug Blocks:

236012

Attachments:

Description	Flags
Patch	thorton: review+
Patch	none

Tim Nguyen (:ntim)

Reported 2022-04-04 08:48:49 PDT

See https://bugs.webkit.org/show_bug.cgi?id=236012#c10 https://webkit-search.igalia.com/webkit/rev/81b1b504044f756417974ca63b3992ee817bb619/Source/WebCore/css/html.css#1370-1377 https://webkit-search.igalia.com/webkit/rev/81b1b504044f756417974ca63b3992ee817bb619/Source/WebCore/style/UserAgentStyle.cpp#198-203 is a good example on how to fix this.

Attachments
Patch (34.29 KB, patch) 2022-04-04 09:33 PDT, Tim Nguyen (:ntim)	thorton: review+	Details Formatted Diff Diff
Patch (34.29 KB, patch) 2022-04-04 11:08 PDT, Tim Nguyen (:ntim)	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2022-04-04 09:05:03 PDT

<rdar://problem/91242629>

Tim Nguyen (:ntim)

Comment 2 2022-04-04 09:33:11 PDT

Created attachment 456579 [details] Patch

Tim Nguyen (:ntim)

Comment 3 2022-04-04 11:08:14 PDT

Created attachment 456591 [details] Patch

Tim Nguyen (:ntim)

Comment 4 2022-04-04 11:11:23 PDT

Committed r292306 (249199@trunk): <https://commits.webkit.org/249199@trunk>

Note You need to log in before you can comment on or make changes to this bug.