Bug 238701

Summary: Start replacing String(const char*) constructor with a String::fromLatin1(const char*) function
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web Template FrameworkAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, beidson, benjamin, changseok, cmarcelo, darin, dino, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, gyuyoung.kim, hi, hta, japhet, jer.noble, joepeck, jsbell, kangil.han, keith_miller, kondapallykalyan, macpherson, mark.lam, menard, mifenton, msaboff, pangle, pascoe, philipj, saam, sergio, tommyw, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 238693    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2022-04-02 12:58:12 PDT
Replace String(const char*) constructor with a String::fromLatin1(const char*) function. It is more consistent with String::fromUTF8() and makes it clearer that input is treated as Latin-1.
Attachments
Patch (95.69 KB, patch)
2022-04-05 20:28 PDT, Chris Dumez
no flags
Patch (94.94 KB, patch)
2022-04-05 21:44 PDT, Chris Dumez
no flags
Chris Dumez
Comment 1 2022-04-05 20:28:44 PDT
Chris Dumez
Comment 2 2022-04-05 21:44:41 PDT
Geoffrey Garen
Comment 3 2022-04-06 10:53:24 PDT
Comment on attachment 456782 [details] Patch r=me
Chris Dumez
Comment 4 2022-04-06 12:05:36 PDT
Comment on attachment 456782 [details] Patch Clearing flags on attachment: 456782 Committed r292487 (?): <https://commits.webkit.org/r292487>
Chris Dumez
Comment 5 2022-04-06 12:05:40 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2022-04-06 12:06:18 PDT
Note You need to log in before you can comment on or make changes to this bug.