Summary: | [GStreamer] gst_video_format_info_component not defined in GStreamer <1.18 | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Diego Pino <dpino> | ||||||||
Component: | New Bugs | Assignee: | Diego Pino <dpino> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | calvaris, pnormand, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Diego Pino
2022-04-01 16:18:10 PDT
Created attachment 456416 [details]
Patch
Comment on attachment 456416 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456416&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:-33 > +#if USE(GSTREAMER) > +#include "GStreamerCommon.h" > +#endif > + > #if ENABLE(VIDEO) && USE(GSTREAMER) > > #include "GraphicsContext.h" > #include "GStreamerAudioMixer.h" > -#include "GStreamerCommon.h" Why is this change needed? Comment on attachment 456416 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456416&action=review > Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:93 > + /* Reverse mapping of info->plane */ . at the end as per coding style. >> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:-33 >> -#include "GStreamerCommon.h" > > Why is this change needed? Please, do not remove this. Created attachment 456574 [details]
Patch
Comment on attachment 456574 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456574&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). You can remove this and then we're good to go! Created attachment 456679 [details]
Patch
(In reply to Philippe Normand from comment #2) > Comment on attachment 456416 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=456416&action=review > > > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:-33 > > +#if USE(GSTREAMER) > > +#include "GStreamerCommon.h" > > +#endif > > + > > #if ENABLE(VIDEO) && USE(GSTREAMER) > > > > #include "GraphicsContext.h" > > #include "GStreamerAudioMixer.h" > > -#include "GStreamerCommon.h" > > Why is this change needed? The reason why I initially introduced this change was because at some point I got a link problem. The linker could not resolve the symbol `webkitGstVideoFormatInfoComponent`. I implemented this change and got the link error solved. However, after the feedback, I undid the change and build from scratch WebKitGTK/WPE and got no link error, so it seemed this change was not needed. Committed r292387 (249252@main): <https://commits.webkit.org/249252@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456679 [details]. |