Bug 238677

Summary: [CMake] Make PlayStation WebDriver build dependent on WPE Backend
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: CMakeAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, ews-watchlist, gyuyoung.kim, ross.kirsling, ryuan.choi, sergio, stephan.szabo
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ross.kirsling: review+, ews-feeder: commit-queue-

Don Olmstead
Reported 2022-04-01 11:55:12 PDT
...
Attachments
Patch (7.49 KB, patch)
2022-04-01 12:55 PDT, Don Olmstead 		ross.kirsling: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2022-04-01 12:55:45 PDT
Created attachment 456391 [details] Patch
Stephan Szabo
Comment 2 2022-04-04 09:35:01 PDT
Comment on attachment 456391 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456391&action=review > Source/WebKit/PlatformPlayStation.cmake:110 > + UIProcess/Automation/libwpe/WebAutomationSessionLibWPE.cpp I don't think this is correct. We should not think that webprocess will only be on for WPE even with the upstream OptionsPlayStation only setting it on in that combination because the downstream merged state will also have it on but doesn't have the wpe support.
Don Olmstead
Comment 3 2023-01-04 15:39:55 PST
Pull request: https://github.com/WebKit/WebKit/pull/8217
EWS
Comment 4 2023-01-05 10:36:00 PST
Committed 258489@main (e217508ca2f1): <https://commits.webkit.org/258489@main> Reviewed commits have been landed. Closing PR #8217 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.