Bug 238669

Summary:

GTK doesn't compile with ENABLE_ACCESSIBILITY=0

Product:

WebKit

Reporter:

Yury Semikhatsky <yurys>

Component:

WebKitGTK

Assignee:

Yury Semikhatsky <yurys>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bugs-noreply, clopez, dennisn, dpino, mcatanzaro

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Yury Semikhatsky

Reported 2022-04-01 10:00:52 PDT

GTK doesn't compile with ENABLE_ACCESSIBILITY=0

Attachments
Patch (2.37 KB, patch) 2022-04-01 10:02 PDT, Yury Semikhatsky	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Yury Semikhatsky

Comment 1 2022-04-01 10:02:27 PDT

Created attachment 456369 [details] Patch

Yury Semikhatsky

Comment 2 2022-04-01 10:05:14 PDT

The error it is fixing is: ../../../Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:697:43: error: use of undeclared identifier 'WEBKIT_WEB_VIEW_ACCESSIBLE' webkitWebViewAccessibleSetWebView(WEBKIT_WEB_VIEW_ACCESSIBLE(webView->priv->accessible.get()), nullptr); ^ ../../../Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:1694:49: error: use of undeclared identifier 'webkitWebViewAccessibleNew' priv->accessible = adoptGRef(ATK_OBJECT(webkitWebViewAccessibleNew(widget))); ^ 2 errors generated.

EWS

Comment 3 2022-04-02 09:00:16 PDT

Committed r292265 (249163@main): <https://commits.webkit.org/249163@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456369 [details].

Michael Catanzaro

Comment 4 2022-04-28 08:17:07 PDT

*** Bug 239837 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.