Bug 23862

Summary: When interrupting accelerated animations, need to simulate style differences
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: hyatt
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 23359    
Attachments:
Description Flags
Patch, changelog
hyatt: review-
Updated patch hyatt: review+

Simon Fraser (smfr)
Reported 2009-02-09 18:13:37 PST
When accelerated animations are running, the softare animation timer is not firing, and we are not constantly changing the RenderStyles (because the animation is being run by the compositing system). This gives great performance, but forces the need to special-case some instances where we compare RenderStyels to know if things are changing.
Attachments
Patch, changelog (7.10 KB, patch)
2009-02-11 13:23 PST, Simon Fraser (smfr) 		hyatt: review-
DetailsFormatted DiffDiff
Updated patch (6.28 KB, patch)
2009-02-11 15:10 PST, Simon Fraser (smfr) 		hyatt: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2009-02-11 13:23:38 PST
Created attachment 27570 [details] Patch, changelog
Simon Fraser (smfr)
Comment 2 2009-02-11 13:25:02 PST
I'll fix the "as a child using inheriting the transform" comment before checkin.
Dave Hyatt
Comment 3 2009-02-11 13:37:08 PST
Comment on attachment 27570 [details] Patch, changelog Typo: "propery" should be "property" Why two bits? It seems like a single flag is good enough, especially given they are both in the same struct. We can revisit if more bits end up in different structs, but for now I'd just do one.
Simon Fraser (smfr)
Comment 4 2009-02-11 15:10:24 PST
Created attachment 27574 [details] Updated patch
Dave Hyatt
Comment 5 2009-02-11 15:13:21 PST
Comment on attachment 27574 [details] Updated patch r=me
Simon Fraser (smfr)
Comment 6 2009-02-11 15:19:10 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/page/animation/ImplicitAnimation.cpp M WebCore/rendering/style/RenderStyle.h M WebCore/rendering/style/StyleRareNonInheritedData.cpp M WebCore/rendering/style/StyleRareNonInheritedData.h Committed r40876
Note You need to log in before you can comment on or make changes to this bug.