Bug 238566

Summary: Add to MiniBrowser the ability to log a textual representation of the AX trees for the current page.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: AccessibilityAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: andresg_22, cfleizach, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Andres Gonzalez
Reported 2022-03-30 12:12:41 PDT
Add to MiniBrowser the ability to log a textual representation of the AX trees for the current page.
Attachments
Patch (7.81 KB, patch)
2022-03-30 12:19 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (7.78 KB, patch)
2022-04-02 07:47 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (7.78 KB, patch)
2022-04-02 11:57 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (7.80 KB, patch)
2022-04-02 12:09 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-03-30 12:12:53 PDT
<rdar://problem/91059308>
Andres Gonzalez
Comment 2 2022-03-30 12:19:07 PDT
Created attachment 456162 [details] Patch
chris fleizach
Comment 3 2022-03-30 13:05:43 PDT
Comment on attachment 456162 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456162&action=review > Tools/MiniBrowser/mac/WK2BrowserWindowController.m:312 > +#pragma clang diagnostic push are you sure this is deprecated? I don't see it
Andres Gonzalez
Comment 4 2022-04-02 07:47:21 PDT
Created attachment 456456 [details] Patch
Andres Gonzalez
Comment 5 2022-04-02 10:06:50 PDT
(In reply to chris fleizach from comment #3) > Comment on attachment 456162 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=456162&action=review > > > Tools/MiniBrowser/mac/WK2BrowserWindowController.m:312 > > +#pragma clang diagnostic push > > are you sure this is deprecated? I don't see it The same thing is done for Save As PDF and WebArchive, so I'm assuming it is needed.
Simon Fraser (smfr)
Comment 6 2022-04-02 10:18:59 PDT
Comment on attachment 456456 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456456&action=review Consider doing this via `notifyutil` instead. > Tools/MiniBrowser/mac/MainMenu.xib:784 > + <menuItem title="Log Accessibility Trees" keyEquivalent="a" id="540"> This is called "log" but throws up a save panel, which is odd. It should also have a ... after the name if it throws a panel.
Andres Gonzalez
Comment 7 2022-04-02 11:57:56 PDT
Created attachment 456463 [details] Patch
Andres Gonzalez
Comment 8 2022-04-02 12:00:49 PDT
(In reply to Simon Fraser (smfr) from comment #6) > Comment on attachment 456456 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=456456&action=review > > Consider doing this via `notifyutil` instead. Thanks, will look into that separately. > > > Tools/MiniBrowser/mac/MainMenu.xib:784 > > + <menuItem title="Log Accessibility Trees" keyEquivalent="a" id="540"> > > This is called "log" but throws up a save panel, which is odd. It should > also have a ... after the name if it throws a panel. Fixed, thanks.
Andres Gonzalez
Comment 9 2022-04-02 12:09:18 PDT
Created attachment 456465 [details] Patch
EWS
Comment 10 2022-04-02 14:54:10 PDT
Committed r292271 (249169@main): <https://commits.webkit.org/249169@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456465 [details].
Note You need to log in before you can comment on or make changes to this bug.