Summary: | Add to MiniBrowser the ability to log a textual representation of the AX trees for the current page. | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andres Gonzalez <andresg_22> | ||||||||||
Component: | Accessibility | Assignee: | Andres Gonzalez <andresg_22> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | andresg_22, cfleizach, simon.fraser, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Andres Gonzalez
2022-03-30 12:12:41 PDT
Created attachment 456162 [details]
Patch
Comment on attachment 456162 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456162&action=review > Tools/MiniBrowser/mac/WK2BrowserWindowController.m:312 > +#pragma clang diagnostic push are you sure this is deprecated? I don't see it Created attachment 456456 [details]
Patch
(In reply to chris fleizach from comment #3) > Comment on attachment 456162 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=456162&action=review > > > Tools/MiniBrowser/mac/WK2BrowserWindowController.m:312 > > +#pragma clang diagnostic push > > are you sure this is deprecated? I don't see it The same thing is done for Save As PDF and WebArchive, so I'm assuming it is needed. Comment on attachment 456456 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456456&action=review Consider doing this via `notifyutil` instead. > Tools/MiniBrowser/mac/MainMenu.xib:784 > + <menuItem title="Log Accessibility Trees" keyEquivalent="a" id="540"> This is called "log" but throws up a save panel, which is odd. It should also have a ... after the name if it throws a panel. Created attachment 456463 [details]
Patch
(In reply to Simon Fraser (smfr) from comment #6) > Comment on attachment 456456 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=456456&action=review > > Consider doing this via `notifyutil` instead. Thanks, will look into that separately. > > > Tools/MiniBrowser/mac/MainMenu.xib:784 > > + <menuItem title="Log Accessibility Trees" keyEquivalent="a" id="540"> > > This is called "log" but throws up a save panel, which is odd. It should > also have a ... after the name if it throws a panel. Fixed, thanks. Created attachment 456465 [details]
Patch
Committed r292271 (249169@main): <https://commits.webkit.org/249169@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456465 [details]. |