Bug 23854

Summary: DumpRenderTree window needs to be autodisplaying when displaying accelerated content
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Tools / TestsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: mitz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 23359    
Attachments:
Description Flags
Patch mitz: review+

Simon Fraser (smfr)
Reported 2009-02-09 14:01:32 PST
When running tests that rely on accelerated compositing, the DumpRenderTree window needs to be setAutodisplay:YES, otherwise the underlying engine does not start accelerated animations correctly.
Attachments
Patch (14.46 KB, patch)
2009-02-09 15:34 PST, Simon Fraser (smfr) 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2009-02-09 15:34:16 PST
Created attachment 27499 [details] Patch
mitz
Comment 2 2009-02-25 11:55:21 PST
Comment on attachment 27499 [details] Patch In pointers to Objective-C instances, the space should go before the * (including in static_cast<>s). I am not sure why you are checking that the WebView responds to _isUsingAcceleratedCompositing. DumpRenderTree is not expected to be used with old WebKit. You don't need to declare and initialize the firstView variable outside the if statement. r=me
Simon Fraser (smfr)
Comment 3 2009-02-25 12:12:52 PST
http://trac.webkit.org/changeset/41224
Note You need to log in before you can comment on or make changes to this bug.