| Summary: | DumpRenderTree window needs to be autodisplaying when displaying accelerated content | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | Tools / Tests | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | mitz | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Mac | ||||||
| OS: | OS X 10.5 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 23359 | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2009-02-09 14:01:32 PST
Created attachment 27499 [details]
Patch
Comment on attachment 27499 [details]
Patch
In pointers to Objective-C instances, the space should go before the * (including in static_cast<>s). I am not sure why you are checking that the WebView responds to _isUsingAcceleratedCompositing. DumpRenderTree is not expected to be used with old WebKit.
You don't need to declare and initialize the firstView variable outside the if statement.
r=me
|