Bug 23854 - DumpRenderTree window needs to be autodisplaying when displaying accelerated content
Summary: DumpRenderTree window needs to be autodisplaying when displaying accelerated ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks: 23359
  Show dependency treegraph
 
Reported: 2009-02-09 14:01 PST by Simon Fraser (smfr)
Modified: 2009-03-02 11:51 PST (History)
1 user (show)

See Also:


Attachments
Patch (14.46 KB, patch)
2009-02-09 15:34 PST, Simon Fraser (smfr)
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2009-02-09 14:01:32 PST
When running tests that rely on accelerated compositing, the DumpRenderTree window needs to be setAutodisplay:YES, otherwise the underlying engine does not start accelerated animations correctly.
Comment 1 Simon Fraser (smfr) 2009-02-09 15:34:16 PST
Created attachment 27499 [details]
Patch
Comment 2 mitz 2009-02-25 11:55:21 PST
Comment on attachment 27499 [details]
Patch

In pointers to Objective-C instances, the space should go before the * (including in static_cast<>s). I am not sure why you are checking that the WebView responds to _isUsingAcceleratedCompositing. DumpRenderTree is not expected to be used with old WebKit.

You don't need to declare and initialize the firstView variable outside the if statement.

r=me
Comment 3 Simon Fraser (smfr) 2009-02-25 12:12:52 PST
http://trac.webkit.org/changeset/41224