Bug 23852

Summary:

Rename Selection to VisibleSelection in preparation for adding new Selection class

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

HTML Editing

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, hyatt, jparent, justin.garcia, ojan

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

23793

Attachments:

Description	Flags
First pass at s/Selection/VisibleSelection	hyatt: review+

Eric Seidel (no email)

Reported 2009-02-09 12:43:52 PST

Rename Selection to VisibleSelection in preparation for adding new Selection class VisibleSeleciton will eventually hold VisiblePositions instead of Positions, and Selection will hold Ranges. The patch is just search/replace and mostly needs a rubber stamp.

Attachments
First pass at s/Selection/VisibleSelection (196.14 KB, patch) 2009-02-09 12:52 PST, Eric Seidel (no email)	hyatt: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2009-02-09 12:52:04 PST

Dave Hyatt

Comment 2 2009-02-09 12:57:57 PST

Comment on attachment 27491 [details] First pass at s/Selection/VisibleSelection r=me

Eric Seidel (no email)

Comment 3 2009-02-09 13:44:05 PST

Committing to http://svn.webkit.org/repository/webkit/trunk ... R WebCore/editing/Selection.cpp => WebCore/editing/VisibleSelection.cpp R WebCore/editing/Selection.h => WebCore/editing/VisibleSelection.h M WebCore/ChangeLog M WebCore/WebCore.base.exp M WebCore/WebCore.pro M WebCore/WebCore.scons M WebCore/WebCore.vcproj/WebCore.vcproj M WebCore/WebCore.xcodeproj/project.pbxproj M WebCore/dom/Element.cpp M WebCore/editing/ApplyStyleCommand.cpp M WebCore/editing/BreakBlockquoteCommand.cpp M WebCore/editing/CompositeEditCommand.cpp M WebCore/editing/CompositeEditCommand.h M WebCore/editing/CreateLinkCommand.cpp M WebCore/editing/DeleteButtonController.cpp M WebCore/editing/DeleteButtonController.h M WebCore/editing/DeleteSelectionCommand.cpp M WebCore/editing/DeleteSelectionCommand.h M WebCore/editing/EditCommand.cpp M WebCore/editing/EditCommand.h M WebCore/editing/Editor.cpp M WebCore/editing/Editor.h M WebCore/editing/EditorCommand.cpp M WebCore/editing/FormatBlockCommand.cpp M WebCore/editing/IndentOutdentCommand.cpp M WebCore/editing/InsertLineBreakCommand.cpp M WebCore/editing/InsertListCommand.cpp M WebCore/editing/InsertParagraphSeparatorCommand.cpp M WebCore/editing/InsertTextCommand.cpp M WebCore/editing/ModifySelectionListLevel.cpp M WebCore/editing/MoveSelectionCommand.cpp M WebCore/editing/RemoveFormatCommand.cpp M WebCore/editing/ReplaceSelectionCommand.cpp M WebCore/editing/SelectionController.cpp M WebCore/editing/SelectionController.h M WebCore/editing/TypingCommand.cpp M WebCore/editing/TypingCommand.h M WebCore/editing/VisiblePosition.cpp M WebCore/editing/htmlediting.cpp M WebCore/editing/htmlediting.h M WebCore/editing/markup.cpp M WebCore/html/HTMLInputElement.cpp M WebCore/html/HTMLInputElement.h M WebCore/html/HTMLTextAreaElement.cpp M WebCore/html/HTMLTextAreaElement.h M WebCore/page/AccessibilityObject.cpp M WebCore/page/AccessibilityObject.h M WebCore/page/AccessibilityRenderObject.cpp M WebCore/page/AccessibilityRenderObject.h M WebCore/page/DOMSelection.cpp M WebCore/page/DOMSelection.h M WebCore/page/DragController.cpp M WebCore/page/EditorClient.h M WebCore/page/EventHandler.cpp M WebCore/page/Frame.cpp M WebCore/page/Frame.h M WebCore/page/Page.cpp M WebCore/page/Page.h M WebCore/page/mac/AccessibilityObjectWrapper.mm M WebCore/rendering/RenderBlock.cpp M WebCore/rendering/RenderTextControl.cpp M WebCore/rendering/RenderTextControl.h M WebCore/rendering/RenderTreeAsText.cpp M WebCore/rendering/RootInlineBox.cpp M WebCore/svg/SVGTextContentElement.cpp M WebKit/mac/ChangeLog M WebKit/mac/WebView/WebFrame.mm M WebKit/mac/WebView/WebView.mm Committed r40793

Note You need to log in before you can comment on or make changes to this bug.