Bug 238490

Summary: Handle pkg_config and declare_args statements in gni-to-cmake.py
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: ANGLEAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, dino, ews-watchlist, gyuyoung.kim, kbr, kkinnunen, kondapallykalyan, kpiddington, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Kenneth Russell
Reported 2022-03-28 22:46:04 PDT
The Source/ThirdParty/ANGLE/gni-to-cmake.py script doesn't currently handle GN's pkg_config and declare_args statements. They don't need to be fully parsed; simply removing them will eliminate some of the manual fixups needed during each ANGLE roll.
Attachments
Patch (2.36 KB, patch)
2022-03-28 22:57 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2022-03-28 22:57:10 PDT
Created attachment 455999 [details] Patch
EWS Watchlist
Comment 2 2022-03-28 22:58:49 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
EWS
Comment 3 2022-03-29 12:09:19 PDT
Committed r292053 (248990@main): <https://commits.webkit.org/248990@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455999 [details].
Radar WebKit Bug Importer
Comment 4 2022-03-29 12:10:19 PDT
<rdar://problem/90997571>
Note You need to log in before you can comment on or make changes to this bug.