Bug 238485

Summary: [JSC] Remove ExecutableToCodeBlockEdge
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, ews-watchlist, gyuyoung.kim, keith_miller, mark.lam, msaboff, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch keith_miller: review+

Yusuke Suzuki
Reported 2022-03-28 21:03:44 PDT
[JSC] Remove ExecutableToCodeBlockEdge
Attachments
Patch (37.42 KB, patch)
2022-03-28 21:04 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (83.40 KB, patch)
2022-03-30 17:35 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (79.69 KB, patch)
2022-03-30 18:23 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (80.91 KB, patch)
2022-03-30 19:28 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (81.99 KB, patch)
2022-03-30 20:40 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (81.69 KB, patch)
2022-03-30 21:22 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (87.44 KB, patch)
2022-03-31 00:05 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (87.46 KB, patch)
2022-03-31 11:38 PDT, Yusuke Suzuki 		keith_miller: review+
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2022-03-28 21:04:12 PDT
Created attachment 455987 [details] Patch
Yusuke Suzuki
Comment 2 2022-03-30 17:35:03 PDT
Created attachment 456188 [details] Patch
Yusuke Suzuki
Comment 3 2022-03-30 18:23:24 PDT
Created attachment 456191 [details] Patch
Yusuke Suzuki
Comment 4 2022-03-30 19:28:42 PDT
Created attachment 456195 [details] Patch
Yusuke Suzuki
Comment 5 2022-03-30 20:40:00 PDT
Created attachment 456197 [details] Patch
Yusuke Suzuki
Comment 6 2022-03-30 21:22:57 PDT
Created attachment 456200 [details] Patch
Yusuke Suzuki
Comment 7 2022-03-31 00:05:54 PDT
Created attachment 456206 [details] Patch
Yusuke Suzuki
Comment 8 2022-03-31 11:38:34 PDT
Created attachment 456262 [details] Patch
Keith Miller
Comment 9 2022-03-31 13:13:56 PDT
Comment on attachment 456262 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456262&action=review r=me with some comments. > Source/JavaScriptCore/heap/Heap.h:1075 > + struct ScriptExecutableSpaceAndSet { Nit: Maybe this should be ScriptExecutableSpaceAndSets* since there's more than one set in here. > Source/JavaScriptCore/runtime/FunctionExecutable.cpp:76 > + // If either of CodeBlocks is not marked yet, we will run output-constraints. Nit: If either CodeBlock is not marked yet > Source/JavaScriptCore/runtime/GlobalExecutable.cpp:46 > + // If the CodeBlocks is not marked yet, we will run output-constraints. Nit: not plural. It should be CodeBlock.
Yusuke Suzuki
Comment 10 2022-03-31 13:24:14 PDT
Comment on attachment 456262 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456262&action=review Thank you! >> Source/JavaScriptCore/heap/Heap.h:1075 >> + struct ScriptExecutableSpaceAndSet { > > Nit: Maybe this should be ScriptExecutableSpaceAndSets* since there's more than one set in here. Right, fixed. >> Source/JavaScriptCore/runtime/FunctionExecutable.cpp:76 >> + // If either of CodeBlocks is not marked yet, we will run output-constraints. > > Nit: If either CodeBlock is not marked yet Fixed. >> Source/JavaScriptCore/runtime/GlobalExecutable.cpp:46 >> + // If the CodeBlocks is not marked yet, we will run output-constraints. > > Nit: not plural. It should be CodeBlock. Fixed.
Yusuke Suzuki
Comment 11 2022-03-31 17:30:50 PDT
mac bots are getting stuck, and I cannot get it tested. Landing it since previous mac-wk2 was green (and mac-AS-debug-wk2 failures are fixed locally).
Yusuke Suzuki
Comment 12 2022-03-31 17:33:46 PDT
Committed r292191 (249094@trunk): <https://commits.webkit.org/249094@trunk>
Radar WebKit Bug Importer
Comment 13 2022-03-31 17:34:18 PDT
<rdar://problem/91136585>
Note You need to log in before you can comment on or make changes to this bug.