Bug 238465

Summary:

WebCore::LegacyRootInlineBox::lineSnapAdjustment should bail out on grid line height < 1

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, mmaxfield, pdr, simon.fraser, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

zalan

Reported 2022-03-28 13:00:59 PDT

Attachments
Patch (1.73 KB, patch) 2022-03-28 13:04 PDT, zalan	no flags	Details Formatted Diff Diff
Patch (1.74 KB, patch) 2022-03-29 10:44 PDT, zalan	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

zalan

Comment 1 2022-03-28 13:04:01 PDT

Antti Koivisto

Comment 2 2022-03-29 09:30:32 PDT

Comment on attachment 455947 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455947&action=review > Source/WebCore/rendering/LegacyRootInlineBox.cpp:363 > - if (!gridLineHeight) > + if (gridLineHeight < 1) could this be if (!roundToInt(gridLineHeight)) ?

zalan

Comment 3 2022-03-29 09:52:57 PDT

(In reply to Antti Koivisto from comment #2) > Comment on attachment 455947 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=455947&action=review > > > Source/WebCore/rendering/LegacyRootInlineBox.cpp:363 > > - if (!gridLineHeight) > > + if (gridLineHeight < 1) > > could this be > > if (!roundToInt(gridLineHeight)) > > ? yes!

zalan

Comment 4 2022-03-29 10:44:27 PDT

EWS

Comment 5 2022-03-29 12:11:16 PDT

Committed r292054 (248991@main): <https://commits.webkit.org/248991@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456043 [details].

Note You need to log in before you can comment on or make changes to this bug.