Bug 238463

Summary: AX ITM: Don't always queue objects for removal if we bail early in AXIsolatedTree::removeSubtreeFromNodeMap
Product: WebKit Reporter: Tyler Wilcock <tyler_w>
Component: AccessibilityAssignee: Tyler Wilcock <tyler_w>
Status: NEW    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ews-feeder: commit-queue-

Tyler Wilcock
Reported 2022-03-28 11:57:08 PDT
In both places we call AXIsolatedTree::removeSubtreeFromNodeMap(AXID axID, ...), we unconditionally remove queue axID for removal in AXIsolatedTree::queueChangesAndRemovals. However, this is sometimes wrong, since AXIsolatedTree::removeSubtreeFromNodeMap can return early without removing axID. We shouldn't be queueing this object for removal in this case.
Attachments
Patch (7.85 KB, patch)
2022-03-30 14:10 PDT, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Patch (8.15 KB, patch)
2022-03-30 14:22 PDT, Tyler Wilcock 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-03-28 11:57:21 PDT
<rdar://problem/90937262>
Tyler Wilcock
Comment 2 2022-03-30 14:10:58 PDT
Created attachment 456173 [details] Patch
Tyler Wilcock
Comment 3 2022-03-30 14:22:22 PDT
Created attachment 456174 [details] Patch
Note You need to log in before you can comment on or make changes to this bug.