Bug 238446

Summary: Issues with WPT exporter
Product: WebKit Reporter: Noam Rosenthal <noam>
Component: Tools / TestsAssignee: Noam Rosenthal <noam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, glenn, gsnedders, jbedard, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 216330    
Attachments:
Description Flags
Patch
none
Patch none

Noam Rosenthal
Reported 2022-03-28 04:37:47 PDT
See https://bugs.webkit.org/show_bug.cgi?id=238373 Applying a patch from a bug doesn't do the right thing: - It requires a \n at the end (https://bugs.webkit.org/show_bug.cgi?id=216603) - It sometimes doesn't fetch the correct master branch, rather something from December 2021 - It thinks it needs to add -expected.html Trying to run this command: ./Tools/Scripts/export-w3c-test-changes -b 238373
Attachments
Patch (2.43 KB, patch)
2022-03-28 05:40 PDT, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Patch (3.68 KB, patch)
2022-03-28 06:45 PDT, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Noam Rosenthal
Comment 1 2022-03-28 05:40:27 PDT
Created attachment 455906 [details] Patch
youenn fablet
Comment 2 2022-03-28 06:24:42 PDT
Comment on attachment 455906 [details] Patch Looks good but some webkitpy tests are failing. Can you double check the tests (hopefully just a rebase).
Noam Rosenthal
Comment 3 2022-03-28 06:45:19 PDT
Created attachment 455912 [details] Patch
Noam Rosenthal
Comment 4 2022-03-28 06:49:00 PDT
(In reply to youenn fablet from comment #2) > Comment on attachment 455906 [details] > Patch > > Looks good but some webkitpy tests are failing. > Can you double check the tests (hopefully just a rebase). Done, needed to add -3 to the test.
EWS
Comment 5 2022-03-28 08:14:24 PDT
Committed r291966 (248931@main): <https://commits.webkit.org/248931@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455912 [details].
Radar WebKit Bug Importer
Comment 6 2022-03-28 08:15:17 PDT
<rdar://problem/90922769>
Tim Nguyen (:ntim)
Comment 7 2022-03-28 09:29:31 PDT
*** Bug 216603 has been marked as a duplicate of this bug. ***
Tim Nguyen (:ntim)
Comment 8 2022-03-28 09:29:40 PDT
*** Bug 216330 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.