Bug 238403

Summary: [GTK] Create bwrapinfo.json file for xdg-desktop-portal
Product: WebKit Reporter: Patrick Griffis <pgriffis>
Component: WebKitGTKAssignee: Patrick Griffis <pgriffis>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, emilio, marmel6942, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=301098
Bug Depends on:    
Bug Blocks: 206533    
Attachments:
Description Flags
Patch ews-feeder: commit-queue-

Patrick Griffis
Reported 2022-03-25 19:22:53 PDT
[GTK] Create bwrapinfo.json file for xdg-desktop-portal
Attachments
Patch (5.27 KB, patch)
2022-03-25 19:23 PDT, Patrick Griffis 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick Griffis
Comment 1 2022-03-25 19:23:56 PDT
Created attachment 455814 [details] Patch
Patrick Griffis
Comment 2 2022-03-25 19:25:41 PDT
This works around a crash in xdg-desktop-portal 1.12.1 and 1.14.0: https://github.com/flatpak/xdg-desktop-portal/issues/709 I have fixed this in future xdg-desktop-portal releases: https://github.com/flatpak/xdg-desktop-portal/pull/746 However the feature is not fully functioning: https://github.com/flatpak/xdg-desktop-portal/issues/747
Michael Catanzaro
Comment 3 2022-03-26 08:45:45 PDT
You intentionally did not set r? here, right?
Patrick Griffis
Comment 4 2022-03-26 08:50:59 PDT
(In reply to Michael Catanzaro from comment #3) > You intentionally did not set r? here, right? Yeah, as-is it doesn't really work, so I guess it was more just to track the issue and document the progress towards getting it working.
Patrick Griffis
Comment 5 2024-01-22 10:23:19 PST
Pull request: https://github.com/WebKit/WebKit/pull/23052
Michael Catanzaro
Comment 6 2024-01-22 10:26:02 PST
*** Bug 267497 has been marked as a duplicate of this bug. ***
tekstryder
Comment 7 2024-01-22 12:29:35 PST
I built webkit2gtk-4.1 2.42.4 + https://github.com/WebKit/WebKit/pull/23052, and can confirm it resolved my original issue reported in bug 267497. Thanks!
EWS
Comment 8 2024-01-22 17:26:56 PST
Committed 273334@main (b9361c774194): <https://commits.webkit.org/273334@main> Reviewed commits have been landed. Closing PR #23052 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.