Bug 238381

Summary: Fix runtime expose scope check for shadow realms
Product: WebKit Reporter: Joseph Griego <joseph.j.griego>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, esprehn+autocc, ews-watchlist, kangil.han, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
darin: review+
Patch
none
Patch none

Description Joseph Griego 2022-03-25 09:30:21 PDT 
Fix runtime expose scope check for shadow realms
Comment 1 Joseph Griego 2022-03-25 09:36:06 PDT 
Created attachment 455774 [details]
Patch
Comment 2 Joseph Griego 2022-03-25 14:13:57 PDT 
Created attachment 455798 [details]
Patch

update binding test expectations
Comment 3 Radar WebKit Bug Importer 2022-04-01 09:31:16 PDT 
<rdar://problem/91166867>
Comment 4 Darin Adler 2022-04-08 09:49:26 PDT 
Comment on attachment 455798 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455798&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:4010
> +      return "([&] { auto* base = $globalObjectPtr; auto obj = jsDynamicCast<$wrapperType*>(base->vm(), base); return obj && $sideCondition; })()";

WebKit coding style uses words rather than non-word abbreviations. So this would be "object" rather than "obj". Same in the many other cases below and above.
Comment 5 Joseph Griego 2022-04-08 10:48:18 PDT 
Thanks Darin, and apologies; I need to add a pre-commit hook for myself to yell when a variable is named `obj`! Old habits are hard to break
Comment 6 Joseph Griego 2022-04-08 14:48:39 PDT 
Created attachment 457120 [details]
Patch
Comment 7 Joseph Griego 2022-04-18 10:29:35 PDT 
Created attachment 457810 [details]
Patch
Comment 8 EWS 2022-04-19 10:26:11 PDT 
Committed r293021 (249760@main): <https://commits.webkit.org/249760@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457810 [details].