Bug 238355

Summary:

String::split() should take in a StringView instead of a String

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Web Template Framework

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, andresg_22, apinheiro, benjamin, cfleizach, cmarcelo, darin, dmazzoni, ews-watchlist, ggaren, hi, jcraig, jdiggs, joepeck, pangle, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=238333

Attachments:

Description	Flags
Patch	none

Description Chris Dumez 2022-03-24 16:24:53 PDT

String::split() should take in a StringView instead of a String, to avoid unnecessary construction of Strings in some instances.

Comment 1 Chris Dumez 2022-03-24 17:03:17 PDT

Created attachment 455705 [details]
Patch

Comment 2 Geoffrey Garen 2022-03-24 19:44:29 PDT

Comment on attachment 455705 [details]
Patch

r=me

Comment 3 EWS 2022-03-24 21:22:59 PDT

Committed r291848 (248860@main): <https://commits.webkit.org/248860@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455705 [details].

Comment 4 Radar WebKit Bug Importer 2022-03-24 21:24:15 PDT

<rdar://problem/90816865>