Bug 238344

Summary:

FileSystem::pathByAppendingComponent() should take in StringViews instead of Strings

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Web Template Framework

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alecflett, beidson, benjamin, cgarcia, cmarcelo, darin, ews-watchlist, galpeter, ggaren, hi, joepeck, jsbell, keith_miller, mark.lam, msaboff, pangle, saam, tzagallo, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	none

Chris Dumez

Reported 2022-03-24 12:52:19 PDT

FileSystem::pathByAppendingComponent() should take in StringViews instead of Strings, to avoid unnecessary String constructor in many instances.

Attachments
Patch (35.23 KB, patch) 2022-03-24 13:31 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (35.08 KB, patch) 2022-03-24 13:37 PDT, Chris Dumez	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (36.14 KB, patch) 2022-03-24 14:04 PDT, Chris Dumez	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (36.28 KB, patch) 2022-03-24 17:48 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.