RESOLVED FIXED 238344
FileSystem::pathByAppendingComponent() should take in StringViews instead of Strings 
https://bugs.webkit.org/show_bug.cgi?id=238344
Summary FileSystem::pathByAppendingComponent() should take in StringViews instead of ...
Chris Dumez
Reported 2022-03-24 12:52:19 PDT
FileSystem::pathByAppendingComponent() should take in StringViews instead of Strings, to avoid unnecessary String constructor in many instances.
Attachments
Patch (35.23 KB, patch)
2022-03-24 13:31 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (35.08 KB, patch)
2022-03-24 13:37 PDT, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (36.14 KB, patch)
2022-03-24 14:04 PDT, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (36.28 KB, patch)
2022-03-24 17:48 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2022-03-24 13:31:26 PDT
Created attachment 455671 [details] Patch
Chris Dumez
Comment 2 2022-03-24 13:37:16 PDT
Created attachment 455673 [details] Patch
Chris Dumez
Comment 3 2022-03-24 14:04:20 PDT
Created attachment 455678 [details] Patch
Geoffrey Garen
Comment 4 2022-03-24 16:08:46 PDT
Comment on attachment 455678 [details] Patch r=me
EWS
Comment 5 2022-03-24 17:17:17 PDT
Tools/Scripts/svn-apply failed to apply attachment 455678 [details] to trunk. Please resolve the conflicts and upload a new patch.
Chris Dumez
Comment 6 2022-03-24 17:48:41 PDT
Created attachment 455714 [details] Patch
EWS
Comment 7 2022-03-24 19:06:21 PDT
Committed r291842 (248856@main): <https://commits.webkit.org/248856@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455714 [details].
Radar WebKit Bug Importer
Comment 8 2022-03-24 19:07:17 PDT
<rdar://problem/90811502>
Wenson Hsieh
Comment 9 2022-03-25 08:55:50 PDT
Committed r291854 (248866@trunk): <https://commits.webkit.org/248866@trunk>
Note You need to log in before you can comment on or make changes to this bug.