Bug 238336

Summary:

Start preparing WebCore for making the String(const char*) constructor explicit

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebCore Misc.

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, alecflett, andresg_22, apinheiro, beidson, benjamin, calvaris, cfleizach, changseok, cmarcelo, darin, dino, dmazzoni, eric.carlson, esprehn+autocc, ews-watchlist, fmalita, ggaren, glenn, gyuyoung.kim, hi, hta, japhet, jcraig, jdiggs, jer.noble, jfernandez, joepeck, jsbell, keith_miller, kondapallykalyan, macpherson, mark.lam, menard, mifenton, msaboff, pangle, pascoe, pdr, philipj, rego, saam, sabouhallawa, samuel_white, schenney, sergio, svillar, tommyw, toyoshim, tzagallo, webkit-bug-importer, yutak

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=238264
https://bugs.webkit.org/show_bug.cgi?id=238408

Bug Depends on:

Bug Blocks:

238693

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none
Patch	none
Patch	none
Patch	ews-feeder: commit-queue-
Patch	none
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none

Chris Dumez

Reported 2022-03-24 10:51:22 PDT

Start preparing WebCore for making the String(const char*) constructor explicit. Making this constructor explicit helps catch at compile time cases where the ""_s prefix is missing on String literals.

Attachments
Patch (415.80 KB, patch) 2022-03-24 13:16 PDT, Chris Dumez	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (421.05 KB, patch) 2022-03-24 13:32 PDT, Chris Dumez	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (421.06 KB, patch) 2022-03-24 14:51 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (423.63 KB, patch) 2022-03-24 14:56 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (423.63 KB, patch) 2022-03-24 16:14 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (419.56 KB, patch) 2022-03-24 17:44 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (416.82 KB, patch) 2022-03-24 19:48 PDT, Chris Dumez	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (411.77 KB, patch) 2022-03-24 20:59 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (411.36 KB, patch) 2022-03-24 21:58 PDT, Chris Dumez	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (411.72 KB, patch) 2022-03-24 22:37 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (412.49 KB, patch) 2022-03-25 07:23 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.