Bug 238311

Summary: [WebGPU] Implement Texture::createView() according to the spec
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: WebGPUAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, djg, kkinnunen, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 238427    
Bug Blocks: 238367, 238428    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch kkinnunen: review+, ews-feeder: commit-queue-

Myles C. Maxfield
Reported 2022-03-23 23:08:29 PDT
[WebGPU] Implement Texture::createView() according to the spec
Attachments
Patch (35.84 KB, patch)
2022-03-23 23:19 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (35.91 KB, patch)
2022-03-24 15:58 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (32.14 KB, patch)
2022-03-26 21:38 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (51.77 KB, patch)
2022-03-27 11:17 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (28.12 KB, patch)
2022-03-27 18:47 PDT, Myles C. Maxfield 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (27.87 KB, patch)
2022-03-27 22:04 PDT, Myles C. Maxfield 		kkinnunen: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2022-03-23 23:19:14 PDT
Created attachment 455611 [details] Patch
Myles C. Maxfield
Comment 2 2022-03-24 11:08:47 PDT
Comment on attachment 455611 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455611&action=review > Source/WebGPU/WebGPU/Texture.mm:1934 > + textureType = MTLTextureType2DMultisampleArray; This needs to be guarded. https://commits.webkit.org/r291805
Myles C. Maxfield
Comment 3 2022-03-24 15:58:56 PDT
Created attachment 455696 [details] Patch
Myles C. Maxfield
Comment 4 2022-03-26 21:38:55 PDT
Created attachment 455863 [details] Patch
Myles C. Maxfield
Comment 5 2022-03-27 11:17:06 PDT
Created attachment 455866 [details] Patch
Myles C. Maxfield
Comment 6 2022-03-27 18:47:11 PDT
Created attachment 455874 [details] Patch
Myles C. Maxfield
Comment 7 2022-03-27 22:04:36 PDT
Created attachment 455887 [details] Patch
Kimmo Kinnunen
Comment 8 2022-03-30 00:27:01 PDT
Comment on attachment 455887 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455887&action=review > Source/WebGPU/WebGPU/Texture.mm:1795 > + // "set resolved.mipLevelCount to texture.[[descriptor]].mipLevelCount â resolved.baseMipLevel." non-ascii chars in comment > Source/WebGPU/WebGPU/Texture.mm:1841 > + // "Set resolved.arrayLayerCount to texture.[[descriptor]].size.depthOrArrayLayers â baseArrayLayer." non-ascii > Source/WebGPU/WebGPU/Texture.mm:2031 > + std::optional<MTLPixelFormat> pixelFormat = MTLPixelFormatInvalid; Either: std::optional<MTLPixelFormat> pixelFormat; or: MTLPixelFormat pixelFormat = MTLPixelFormatInvalid; not both?
Radar WebKit Bug Importer
Comment 9 2022-03-30 23:09:15 PDT
<rdar://problem/91087004>
Myles C. Maxfield
Comment 10 2022-03-31 01:27:09 PDT
Committed r292145 (249052@trunk): <https://commits.webkit.org/249052@trunk>
Note You need to log in before you can comment on or make changes to this bug.