Summary: | [Gtk] Running automake fails with current automake/libtool | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Calvin Walton <calvin.walton> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Calvin Walton
2009-02-07 08:36:17 PST
Created attachment 27450 [details]
Patch adding AC_PROG_CXX macro to configure.ac
I've created a patch adding a check for AC_PROG_CXX to the configure.ac file.
I've tried to follow the committing guidelines as close as possible, please let me know if I got anything wrong!
Please use the prepare-ChaneLog utility and upload a new patch. Comment on attachment 27450 [details] Patch adding AC_PROG_CXX macro to configure.ac Please see http://webkit.org/coding/contributing.html for future patches. Your manual creation of the ChangeLog is creating more work for me. Ah, sorry about that; I was about to redo the patch using the proper tools, but it seems you beat me to it. This change is bogus, I believe. WebKit's configure.ac already calls the AC_PROG_CXX macro through WEBKIT_INIT, which is defined in its webkit.m4, and protects the call so that CXXFLAGS is not modified incorrectly. With this change debugging symbols are being added because the first AC_PROG_CXX is not protected to not allow CXXFLAGS modification. This caused: https://bugs.webkit.org/show_bug.cgi?id=23939 We need a better way to shut up automake1.10, although my (Debian) automake 1.10 did not complain about AC_PROG_CXX missing when I removed the call added by this change. Hmm. I investigated a little more, and found that this only happened on one of my two computers (both of which are supposed to have the same build system tool versions). I suspect deeper problems with the one computer specifically now, and it looks like the original code was correct - the comment on bug #23939 says that this macro is already called, with debug compiler flag protection. It would probably be best to revert this change, fixing bug #23939 at the same time. Sorry about that :/ |