Bug 23939 - Release build being built with debugging symbols
Summary: Release build being built with debugging symbols
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Gustavo Noronha (kov)
Depends on:
Reported: 2009-02-12 16:55 PST by Gustavo Noronha (kov)
Modified: 2009-02-17 04:49 PST (History)
1 user (show)

See Also:

proposed fix (1.36 KB, patch)
2009-02-12 17:29 PST, Gustavo Noronha (kov)
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2009-02-12 16:55:37 PST
The autoconf build system was recently modified to call AC_PROG_CXX. This macro is adding -g and -O2 to CXXFLAGS, which ends up making the build have debug symbols.
Comment 1 Gustavo Noronha (kov) 2009-02-12 17:29:37 PST
Created attachment 27634 [details]
proposed fix

While searching for a way to protect CXXFLAGS from modification I found webkit.m4 where WEBKIT_INIT (which is called by our configure.ac) is defined. There is already an AC_PROG_CXX call there, which protects CXXFLAGS against changes, and which is expanded as part of WEBKIT_INIT, so adding a second call without the protection is no good.

I tested automake1.10 here after removing the second call, and it did not complain about it missing, so I am not sure an issue actually exists.
Comment 2 Calvin Walton 2009-02-12 20:57:03 PST
I'm afraid to say this is my fault, due to a computer that had a broken autotools installation. The original code was in fact correct, and this change should be reverted.
Comment 3 Alexey Proskuryakov 2009-02-16 02:31:28 PST
Comment on attachment 27634 [details]
proposed fix

Comment 4 Gustavo Noronha (kov) 2009-02-17 04:49:03 PST
Landed in r41038.