Summary: | REGRESSION (r290794): [ iOS Debug ] 4 editing/selection/* tests are constant timeouts | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dawn Morningstar <Morningstar> | ||||||
Component: | New Bugs | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | akeerthi, hi, katherine_cheney, megan_gardner, thorton, webkit-bot-watchers-bugzilla, webkit-bug-importer, wenson_hsieh | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Dawn Morningstar
2022-03-21 14:42:29 PDT
Suspected regression point: r290794 as this is the only revision that modifies iOS in range, but further testing is required to confirm. ([iOS] Further reduce hangs underneath) (In reply to Matteo Flores from comment #2) > Suspected regression point: r290794 as this is the only revision that > modifies iOS in range, but further testing is required to confirm. > ([iOS] Further reduce hangs underneath) I think this makes sense, as a regression point. That said, I think these tests should eventually finish (it just takes longer now). There might be some adjustments we can make to keep these tests within the time limit for non-fast layout tests, though — I'll take a look (In reply to Wenson Hsieh from comment #3) > (In reply to Matteo Flores from comment #2) > > Suspected regression point: r290794 as this is the only revision that > > modifies iOS in range, but further testing is required to confirm. > > ([iOS] Further reduce hangs underneath) > > I think this makes sense, as a regression point. > > That said, I think these tests should eventually finish (it just takes > longer now). There might be some adjustments we can make to keep these tests > within the time limit for non-fast layout tests, though — I'll take a look Perfect I also thought the same thing, that they just take longer now. There always is the option as marking these as [ Slow ]. (In reply to Matteo Flores from comment #4) > (In reply to Wenson Hsieh from comment #3) > > (In reply to Matteo Flores from comment #2) > > > Suspected regression point: r290794 as this is the only revision that > > > modifies iOS in range, but further testing is required to confirm. > > > ([iOS] Further reduce hangs underneath) > > > > I think this makes sense, as a regression point. > > > > That said, I think these tests should eventually finish (it just takes > > longer now). There might be some adjustments we can make to keep these tests > > within the time limit for non-fast layout tests, though — I'll take a look > > Perfect I also thought the same thing, that they just take longer now. There > always is the option as marking these as [ Slow ]. Oh, good point. Perhaps we could try that first, and see if it mitigates these failures? (While I continue to investigate). (In reply to Wenson Hsieh from comment #5) > Oh, good point. Perhaps we could try that first, and see if it mitigates > these failures? (While I continue to investigate). Indeed I will do that right away. r291584 Slow expectation has been set. Hopefully this will resolve the issue. Looks like this helped three of them, but not editing/selection/move-by-word-visually-multi-line.html Created attachment 455861 [details]
Patch
Created attachment 455862 [details]
Fix macOS build
Comment on attachment 455862 [details]
Fix macOS build
Thanks for the review!
Committed r292005 (248955@main): <https://commits.webkit.org/248955@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455862 [details]. *** Bug 238479 has been marked as a duplicate of this bug. *** |