| Summary: | [TextureMapper] Split GraphicsContextGLTextureMapper into two classes | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||
| Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | alex, annulen, cmarcelo, dino, ews-watchlist, gyuyoung.kim, kondapallykalyan, luiz, ryuan.choi, sergio, webkit-bug-importer, zdobersek | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 237649, 238223 | ||||||||
| Attachments: |
|
||||||||
|
Description
Zan Dobersek
2022-03-21 07:11:59 PDT
Created attachment 455244 [details]
Patch
Comment on attachment 455244 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455244&action=review LGTM! Check the option I pointed out to remove more code and the wincairo failure, I think it is not related but we want to make sure we do not break it. > Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp:123 > +#if USE(LIBEPOXY) && USE(OPENGL_ES) && ENABLE(WEBGL2) > + // Bail if GLES3 was requested but cannot be provided. > + if (attributes.webGLVersion == GraphicsContextGLWebGLVersion::WebGL2 && !epoxy_is_desktop_gl() && epoxy_gl_version() < 30) > + return nullptr; > +#endif I think we can remove this in the ANGLE case. Created attachment 455339 [details]
Patch for landing
Found 1 new test failure: imported/w3c/web-platform-tests/webstorage/event_case_sensitive.html Committed r291610 (248703@main): <https://commits.webkit.org/248703@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455339 [details]. |