Bug 238141

Summary: [TextureMapper] Split GraphicsContextGLTextureMapper into two classes
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: alex, annulen, cmarcelo, dino, ews-watchlist, gyuyoung.kim, kondapallykalyan, luiz, ryuan.choi, sergio, webkit-bug-importer, zdobersek
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 237649, 238223    
Attachments:
Description Flags
Patch
none
Patch for landing none

Zan Dobersek
Reported 2022-03-21 07:11:59 PDT
[TextureMapper] Split GraphicsContextGLTextureMapper into two classes
Attachments
Patch (27.26 KB, patch)
2022-03-21 07:20 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (26.81 KB, patch)
2022-03-21 23:57 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2022-03-21 07:20:05 PDT
Created attachment 455244 [details] Patch
Alejandro G. Castro
Comment 2 2022-03-21 13:25:40 PDT
Comment on attachment 455244 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455244&action=review LGTM! Check the option I pointed out to remove more code and the wincairo failure, I think it is not related but we want to make sure we do not break it. > Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp:123 > +#if USE(LIBEPOXY) && USE(OPENGL_ES) && ENABLE(WEBGL2) > + // Bail if GLES3 was requested but cannot be provided. > + if (attributes.webGLVersion == GraphicsContextGLWebGLVersion::WebGL2 && !epoxy_is_desktop_gl() && epoxy_gl_version() < 30) > + return nullptr; > +#endif I think we can remove this in the ANGLE case.
Zan Dobersek
Comment 3 2022-03-21 23:57:15 PDT
Created attachment 455339 [details] Patch for landing
EWS
Comment 4 2022-03-22 03:05:13 PDT
Found 1 new test failure: imported/w3c/web-platform-tests/webstorage/event_case_sensitive.html
EWS
Comment 5 2022-03-22 03:19:33 PDT
Committed r291610 (248703@main): <https://commits.webkit.org/248703@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455339 [details].
Radar WebKit Bug Importer
Comment 6 2022-03-22 03:20:16 PDT
<rdar://problem/90625148>
Note You need to log in before you can comment on or make changes to this bug.