Bug 238024

Summary: Recycling a webgl context when it has been lost and restored causes a crash
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebGLAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, dino, esprehn+autocc, ews-watchlist, ggaren, gyuyoung.kim, japhet, kbr, kkinnunen, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=240821
Attachments:
Description Flags
wip
none
Patch
none
Patch for landing none

Kimmo Kinnunen
Reported 2022-03-17 07:40:02 PDT
Recycling a webgl context when it has been lost and restored causes a crash lose a context schedule it for restore force the context lost due to "recycling", e.g. exceeding active context limit
Attachments
wip (27.37 KB, patch)
2022-03-17 07:43 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch (33.14 KB, patch)
2022-03-17 12:06 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch for landing (33.94 KB, patch)
2022-03-18 00:50 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1 2022-03-17 07:43:36 PDT
Created attachment 454973 [details] wip
Kimmo Kinnunen
Comment 2 2022-03-17 12:06:05 PDT
Created attachment 455000 [details] Patch
Geoffrey Garen
Comment 3 2022-03-17 12:18:12 PDT
Comment on attachment 455000 [details] Patch r=me All red! I feel bad for taking away the ability to r+ this patch from Alex Christensen.
Kimmo Kinnunen
Comment 4 2022-03-18 00:50:37 PDT
Created attachment 455074 [details] Patch for landing
EWS
Comment 5 2022-03-18 05:19:10 PDT
Committed r291477 (248593@main): <https://commits.webkit.org/248593@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455074 [details].
Radar WebKit Bug Importer
Comment 6 2022-03-18 05:20:18 PDT
<rdar://problem/90481699>
Note You need to log in before you can comment on or make changes to this bug.