Summary: | [GTK][WPE] m_compositorThread ASSERT in TextureMapper classes can just be used in debug mode | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alejandro G. Castro <alex> | ||||||
Component: | WebKitGTK | Assignee: | Alejandro G. Castro <alex> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bugs-noreply, cgarcia, cmarcelo, ews-watchlist, kondapallykalyan, luiz, mcatanzaro | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Alejandro G. Castro
2022-03-17 06:39:23 PDT
Created attachment 454966 [details]
Patch
Comment on attachment 454966 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454966&action=review > Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyGL.cpp:92 > ASSERT(m_compositorThread == &Thread::current()); > +#if ASSERT_ENABLED > + m_compositorThread = nullptr; > +#endif Indentation is off here (In reply to Michael Catanzaro from comment #2) > Comment on attachment 454966 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=454966&action=review > > > Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyGL.cpp:92 > > ASSERT(m_compositorThread == &Thread::current()); > > +#if ASSERT_ENABLED > > + m_compositorThread = nullptr; > > +#endif > > Indentation is off here Right! Thanks for the review Michael. Created attachment 455007 [details]
Patch for landing
Committed r291442 (248566@main): <https://commits.webkit.org/248566@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455007 [details]. |