Bug 237915

Summary: Suspend newly created NetworkStorageManager if network process is or will be suspended
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: Website StorageAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, sihui_liu, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch for landing none

Sihui Liu
Reported 2022-03-15 12:49:23 PDT
...
Attachments
Patch (3.39 KB, patch)
2022-03-15 13:03 PDT, Sihui Liu 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (3.39 KB, patch)
2022-03-15 13:25 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.88 KB, patch)
2022-03-15 21:22 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2022-03-15 13:03:44 PDT
Created attachment 454746 [details] Patch
Sihui Liu
Comment 2 2022-03-15 13:25:33 PDT
Created attachment 454748 [details] Patch
Chris Dumez
Comment 3 2022-03-15 15:46:23 PDT
Comment on attachment 454748 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454748&action=review > Source/WebKit/NetworkProcess/NetworkProcess.cpp:2159 > + m_isSuspended = false; Please move this inside NetworkProcess::resume(). Alternatively, we could move the logic from resume() to here as I don't think it is needed anymore. I think we use to have the logic in resume() so we could call it from here and in suspension cancellation. However, I don't think suspension cancellation is a thing anymore.
Sihui Liu
Comment 4 2022-03-15 21:22:27 PDT
Created attachment 454795 [details] Patch for landing
EWS
Comment 5 2022-03-16 00:21:11 PDT
Committed r291334 (248473@main): <https://commits.webkit.org/248473@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454795 [details].
Radar WebKit Bug Importer
Comment 6 2022-03-16 00:22:16 PDT
<rdar://problem/90355365>
Note You need to log in before you can comment on or make changes to this bug.