| Summary: | RemoteGraphicsContextGLProxy omits context lost checks for back and front buffer access functions | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> | ||||||
| Component: | WebGL | Assignee: | Kimmo Kinnunen <kkinnunen> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dino, kbr, kkinnunen, mmaxfield, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | Other | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=237893 | ||||||||
| Attachments: |
|
||||||||
|
Description
Kimmo Kinnunen
2022-03-15 07:02:30 PDT
Created attachment 454704 [details]
Patch
Comment on attachment 454704 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454704&action=review > Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp:142 > + buffer.context().clearRect({ IntPoint(), buffer.backendSize() }); I’m a little confused. If the context is lost, how can you use the context to clearRect()? Created attachment 454739 [details]
Patch
(In reply to Myles C. Maxfield from comment #3) > > > Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp:142 > > + buffer.context().clearRect({ IntPoint(), buffer.backendSize() }); > > I’m a little confused. If the context is lost, how can you use the context > to clearRect()? It's different context (graphics context of the image buffer, vs graphicscontextgl of webgl) However, that's a good point -- if the context is lost, the GPU Process is unreliable and will be shut down, so the image buffer drawing does not make sense either. I'll remove this for now. Committed r291314 (248453@main): <https://commits.webkit.org/248453@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454739 [details]. |