Bug 237868

Summary: Serialize grid-template correctly
Product: WebKit Reporter: Matt Woodrow <mattwoodrow>
Component: CSSAssignee: Matt Woodrow <mattwoodrow>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jfernandez, macpherson, menard, rego, svillar, webkit-bug-importer
Priority: P3 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 204611    
Attachments:
Description Flags
Patch
none
Patch
dino: review+, ews-feeder: commit-queue-
Patch for landing none

Description Matt Woodrow 2022-03-14 19:55:25 PDT 
grid-template has an option to take an interleaved set of lines names, track sizes and area names, and we're supposed to serialise the result back in the same format rather than listing areas at the end.
Comment 1 Radar WebKit Bug Importer 2022-03-14 19:55:46 PDT 
<rdar://problem/90284707>
Comment 2 Matt Woodrow 2022-03-14 20:06:47 PDT 
Created attachment 454654 [details]
Patch
Comment 3 Matt Woodrow 2022-03-15 13:38:22 PDT 
Created attachment 454752 [details]
Patch
Comment 4 Dean Jackson 2022-03-25 12:56:59 PDT 
Comment on attachment 454752 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454752&action=review

> Source/WebCore/css/StyleProperties.cpp:835
> +    && downcast<CSSPrimitiveValue>(value.get())->valueID() == CSSValueNone;

Nit: We indent this line

> Source/WebCore/css/StyleProperties.cpp:837
> +}
> +static bool isValueID(const Ref<CSSValue>& value, CSSValueID id)

Nit: Need a blank line between these (and others)
Comment 5 Matt Woodrow 2022-03-27 14:08:28 PDT 
Created attachment 455867 [details]
Patch for landing
Comment 6 EWS 2022-03-27 20:04:47 PDT 
Committed r291955 (248922@main): <https://commits.webkit.org/248922@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455867 [details].