Bug 237867

Summary: Stop using DYLD_INTERPOSE
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ews-watchlist, glenn, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Alex Christensen 2022-03-14 19:38:20 PDT
Stop using DYLD_INTERPOSE
Comment 1 Alex Christensen 2022-03-14 19:40:27 PDT
Created attachment 454653 [details]
Patch
Comment 2 Alexey Proskuryakov 2022-03-15 09:04:52 PDT
Comment on attachment 454653 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454653&action=review

> Source/WebCore/ChangeLog:12
> +        It is currently only used for tests in editing/secure-input which continue to pass
> +        as much as they did before this change.

So... Should those tests be deleted as they apparently don't test anything based on this finding?
Comment 3 Alex Christensen 2022-03-15 09:55:46 PDT
Comment on attachment 454653 [details]
Patch

I'm not sure about deleting those tests.  They certainly don't currently reflect whether EnableSecureEventInput has been called, but they might exercise some code that is otherwise unexercised.
Comment 4 EWS 2022-03-15 10:32:14 PDT
Committed r291302 (248441@main): <https://commits.webkit.org/248441@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454653 [details].
Comment 5 Radar WebKit Bug Importer 2022-03-15 10:33:17 PDT
<rdar://problem/90314693>