WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
237867
Stop using DYLD_INTERPOSE
https://bugs.webkit.org/show_bug.cgi?id=237867
Summary
Stop using DYLD_INTERPOSE
Alex Christensen
Reported
2022-03-14 19:38:20 PDT
Stop using DYLD_INTERPOSE
Attachments
Patch
(21.98 KB, patch)
2022-03-14 19:40 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alex Christensen
Comment 1
2022-03-14 19:40:27 PDT
Created
attachment 454653
[details]
Patch
Alexey Proskuryakov
Comment 2
2022-03-15 09:04:52 PDT
Comment on
attachment 454653
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=454653&action=review
> Source/WebCore/ChangeLog:12 > + It is currently only used for tests in editing/secure-input which continue to pass > + as much as they did before this change.
So... Should those tests be deleted as they apparently don't test anything based on this finding?
Alex Christensen
Comment 3
2022-03-15 09:55:46 PDT
Comment on
attachment 454653
[details]
Patch I'm not sure about deleting those tests. They certainly don't currently reflect whether EnableSecureEventInput has been called, but they might exercise some code that is otherwise unexercised.
EWS
Comment 4
2022-03-15 10:32:14 PDT
Committed
r291302
(
248441@main
): <
https://commits.webkit.org/248441@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 454653
[details]
.
Radar WebKit Bug Importer
Comment 5
2022-03-15 10:33:17 PDT
<
rdar://problem/90314693
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug