Bug 237828

Summary: [GStreamer] Avoid auto-selection of hole punching player
Product: WebKit Reporter: Enrique Ocaña <eocanha>
Component: MediaAssignee: Enrique Ocaña <eocanha>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cgarcia, eric.carlson, ews-watchlist, glenn, jer.noble, magomez, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Enrique Ocaña
Reported 2022-03-14 06:46:40 PDT
The hole punch player private shouldn't be automatically selected when the mime type is empty or unknown.
Attachments
Patch (4.55 KB, patch)
2022-03-14 07:01 PDT, Enrique Ocaña 		no flags
DetailsFormatted DiffDiff
Patch (4.70 KB, patch)
2022-03-14 07:03 PDT, Enrique Ocaña 		no flags
DetailsFormatted DiffDiff
Patch (4.61 KB, patch)
2022-03-15 10:50 PDT, Enrique Ocaña 		no flags
DetailsFormatted DiffDiff
Patch (4.61 KB, patch)
2022-03-15 12:32 PDT, Enrique Ocaña 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Enrique Ocaña
Comment 1 2022-03-14 07:01:36 PDT
Created attachment 454588 [details] Patch
Enrique Ocaña
Comment 2 2022-03-14 07:03:08 PDT
Created attachment 454589 [details] Patch
Miguel Gomez
Comment 3 2022-03-14 07:44:40 PDT
Looks good to me Enrique!
Enrique Ocaña
Comment 4 2022-03-15 04:46:43 PDT
The editing/spelling/spellcheck-api-crash.html failure in the iOS-15-Simulator-WK2-Tests-EWS bot is unrelated to this patch and should be ignored. Actually, I've been seeing that failure in some other unrelated EWS patch submissions these days.
Xabier Rodríguez Calvar
Comment 5 2022-03-15 07:31:29 PDT
Comment on attachment 454589 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454589&action=review > Source/WebCore/platform/graphics/holepunch/MediaPlayerPrivateHolePunch.cpp:191 > + if (mimeType.isEmpty() || !(mimeTypeCache().contains(mimeType))) !(mimeTypeCache().contains(mimeType)) -> !mimeTypeCache().contains(mimeType)
Carlos Garcia Campos
Comment 6 2022-03-15 07:32:10 PDT
Comment on attachment 454589 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454589&action=review > Source/WebCore/platform/graphics/holepunch/MediaPlayerPrivateHolePunch.cpp:189 > + if (m_player) { Return early. >> Source/WebCore/platform/graphics/holepunch/MediaPlayerPrivateHolePunch.cpp:191 >> + if (mimeType.isEmpty() || !(mimeTypeCache().contains(mimeType))) > > !(mimeTypeCache().contains(mimeType)) -> !mimeTypeCache().contains(mimeType) Extra parentheses after ! > Source/WebCore/platform/graphics/holepunch/MediaPlayerPrivateHolePunch.h:79 > - MediaPlayer::NetworkState networkState() const final { return MediaPlayer::NetworkState::Empty; }; > + MediaPlayer::NetworkState networkState() const final; We don't need to move this to the cpp, just return m_networkState here.
Enrique Ocaña
Comment 7 2022-03-15 10:50:13 PDT
Created attachment 454729 [details] Patch
Enrique Ocaña
Comment 8 2022-03-15 12:32:42 PDT
Created attachment 454741 [details] Patch
EWS
Comment 9 2022-03-16 03:17:21 PDT
Committed r291337 (248476@main): <https://commits.webkit.org/248476@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454741 [details].
Radar WebKit Bug Importer
Comment 10 2022-03-16 03:18:16 PDT
<rdar://problem/90360852>
Note You need to log in before you can comment on or make changes to this bug.