Bug 237827

Summary: Keep service workers alive when they are inspected even though they should be terminated
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, cdumez, nham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

youenn fablet
Reported 2022-03-14 06:32:43 PDT
Keep service workers alive when they are inspected even though they should be terminated
Attachments
Patch (19.61 KB, patch)
2022-03-15 04:24 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (36.79 KB, patch)
2022-03-16 07:14 PDT, youenn fablet 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (36.66 KB, patch)
2022-03-16 07:56 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (32.63 KB, patch)
2022-03-16 09:01 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2022-03-14 08:58:31 PDT
<rdar://88313935>
youenn fablet
Comment 2 2022-03-15 04:24:13 PDT
Created attachment 454693 [details] Patch
youenn fablet
Comment 3 2022-03-16 07:14:34 PDT
Created attachment 454830 [details] Patch
youenn fablet
Comment 4 2022-03-16 07:56:19 PDT
Created attachment 454833 [details] Patch
youenn fablet
Comment 5 2022-03-16 09:01:16 PDT
Created attachment 454843 [details] Patch
youenn fablet
Comment 6 2022-03-17 08:21:25 PDT
Comment on attachment 454843 [details] Patch Error unrelated
Alex Christensen
Comment 7 2022-03-17 14:12:29 PDT
Comment on attachment 454843 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454843&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/PushAPI.mm:548 > + // We delay so that the push message will happen before the unregistration of the service worker client. > + sleep(0.5); Wouldn't this be better to wait until pushMessageProcessed is true?
youenn fablet
Comment 8 2022-03-18 00:14:25 PDT
(In reply to Alex Christensen from comment #7) > Comment on attachment 454843 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=454843&action=review > > > Tools/TestWebKitAPI/Tests/WebKitCocoa/PushAPI.mm:548 > > + // We delay so that the push message will happen before the unregistration of the service worker client. > > + sleep(0.5); > > Wouldn't this be better to wait until pushMessageProcessed is true? The service worker is waiting to resolve the push message when there is no more clients, so we cannot wait here, we wait after we close the client.
EWS
Comment 9 2022-03-18 00:34:25 PDT
Committed r291467 (248583@main): <https://commits.webkit.org/248583@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454843 [details].
Note You need to log in before you can comment on or make changes to this bug.