Bug 237815

Summary: [macOS] Tooltip no longer disappears after leaving hovered element
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: PlatformAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: akeerthi, hi, katherine_cheney, megan_gardner, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Fix debug builds
none
Patch none

Description Wenson Hsieh 2022-03-12 21:00:46 PST 
rdar://90187247
Comment 1 Wenson Hsieh 2022-03-12 21:43:54 PST 
Created attachment 454547 [details]
Patch
Comment 2 Wenson Hsieh 2022-03-12 22:23:59 PST 
Created attachment 454550 [details]
Fix debug builds
Comment 3 Alexey Proskuryakov 2022-03-14 13:46:06 PDT 
Comment on attachment 454550 [details]
Fix debug builds

View in context: https://bugs.webkit.org/attachment.cgi?id=454550&action=review

> Source/WebKit/ChangeLog:9
> +        On certain versions of macOS, AppKit's tooltip management system installs tracking areas (NSTrackingArea) using

Do we need to do anything in Legacy WebKit for this? I don't know much about NSTrackingAreas, but I know that there is code for those in WebHTMLView.mm.
Comment 4 Wenson Hsieh 2022-03-14 13:59:20 PDT 
Comment on attachment 454550 [details]
Fix debug builds

(In reply to Alexey Proskuryakov from comment #3)
> Comment on attachment 454550 [details]
> Fix debug builds
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=454550&action=review
> 
> > Source/WebKit/ChangeLog:9
> > +        On certain versions of macOS, AppKit's tooltip management system installs tracking areas (NSTrackingArea) using
> 
> Do we need to do anything in Legacy WebKit for this? I don't know much about
> NSTrackingAreas, but I know that there is code for those in WebHTMLView.mm.

Good catch — confirmed that the same bug repros in WK1 as well. I suppose I'll fix both in this same patch.
Comment 5 Wenson Hsieh 2022-03-14 16:18:19 PDT 
Created attachment 454634 [details]
Patch
Comment 6 Wenson Hsieh 2022-03-15 06:47:59 PDT 
Comment on attachment 454634 [details]
Patch

Thanks for the review!
Comment 7 EWS 2022-03-15 07:26:47 PDT 
Committed r291287 (248426@main): <https://commits.webkit.org/248426@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454634 [details].