Bug 23781

Summary: Call RenderView::willMoveOffscreen/didMoveOnscreen, and update layers correctly
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 23359    
Attachments:
Description Flags
Patch, changelog hyatt: review+

Simon Fraser (smfr)
Reported 2009-02-05 21:26:26 PST
We need to call RenderView::willMoveOffscreen() and didMoveOnscreen() when the document goes in and out of the page cache, so that we hook/unhook layers correctly. We also need to them in attach/detach, again to hook up the layers. Finally, we need to update layers in Document::updateRendering().
Attachments
Patch, changelog (3.74 KB, patch)
2009-02-05 22:26 PST, Simon Fraser (smfr) 		hyatt: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2009-02-05 22:26:14 PST
Created attachment 27381 [details] Patch, changelog
Dave Hyatt
Comment 2 2009-02-05 22:59:29 PST
Comment on attachment 27381 [details] Patch, changelog r=me Just yank the amusing FIXME from Eric rather than adding to it. :)
Simon Fraser (smfr)
Comment 3 2009-02-06 09:05:16 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/dom/Document.cpp Committed r40719
Note You need to log in before you can comment on or make changes to this bug.